Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(customElement): properly remove hyphenated attribute #12143

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

edison1105
Copy link
Member

close #12139

Copy link

github-actions bot commented Oct 10, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+9 B) 38.1 kB (+5 B) 34.2 kB (+41 B)
vue.global.prod.js 160 kB (+9 B) 58 kB (+7 B) 51.6 kB (+21 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB (+9 B) 18.9 kB (+11 B) 17.3 kB (+11 B)
createApp 55.7 kB (+9 B) 21.4 kB (+11 B) 19.6 kB (-27 B)
createSSRApp 59.7 kB (+9 B) 23.1 kB (+10 B) 21 kB (+15 B)
defineCustomElement 60.5 kB (+9 B) 23 kB (+8 B) 20.9 kB (+35 B)
overall 69.4 kB (+9 B) 26.5 kB (+8 B) 24.1 kB (+76 B)

Copy link

pkg-pr-new bot commented Oct 10, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12143

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12143

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12143

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12143

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12143

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12143

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12143

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12143

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12143

vue

pnpm add https://pkg.pr.new/vue@12143

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12143

commit: 107ec22

@edison1105 edison1105 changed the title fix(customElement): properly remove hyphenated attribute with null value fix(customElement): properly remove hyphenated attribute Oct 10, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: custom elements labels Oct 10, 2024
@yyx990803 yyx990803 merged commit e16e9a7 into main Oct 11, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/12139 branch October 11, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: custom elements
Projects
None yet
2 participants