feat(runtime-core): add 'container' to component instance #8195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi could someone please review it? |
sxzz
approved these changes
Sep 2, 2023
sxzz
force-pushed
the
instance-container
branch
from
bf6152d
to
9bab0a5
Compare
Size ReportBundles
Usages
|
sxzz
force-pushed
the
minor
branch
2 times, most recently
from
dc30885
to
be91d43
Compare
baiwusanyu-c
suggested changes
Sep 22, 2023
Co-authored-by: 白雾三语 <[email protected]>
eagleoflqj
force-pushed
the
instance-container
branch
from
d2c8885
to
bf0795a
Compare
baiwusanyu-c
approved these changes
Sep 24, 2023
sxzz
force-pushed
the
minor
branch
3 times, most recently
from
4a6258b
to
5d93a55
Compare
pikax
added
ready to merge
yyx990803
added a commit
that referenced
this pull request
Aug 3, 2024
|
I think this specific case should be solved in a more custom-element-specific way, and should also avoid relying on see 5a1a89b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6113
Testcase shows how to use it in
setupof a custom element.If a component aims for both vue component and web component, one can use
ins.container instanceof DocumentFragmentto distinguish.