Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Vue's language color on GitHub #3674

Closed
wenfangdu opened this issue Apr 26, 2021 · 5 comments
Closed

Change Vue's language color on GitHub #3674

wenfangdu opened this issue Apr 26, 2021 · 5 comments

Comments

@wenfangdu
Copy link

wenfangdu commented Apr 26, 2021

What problem does this feature solve?

Currently, Vue's language color on GitHub is #2c3e50, which feels less Vueish than #41b883 in the below logo and kind of hard to see in GitHub's dark mode, can we consider changing #2c3e50 to #41b883?

image

These comments explain why the current color was chosen. GitHub Linguist used to have a requirement that all colors had to be visually distinct from each other but they dropped that requirement in #4978.

And according to Changing the color associated with a language, we have to reach a consensus to make such change.

What does the proposed API look like?

#2c3e50 to #41b883

@posva
Copy link
Member

posva commented Apr 26, 2021

Apparently, there was a reason for the dark color to be picked in the past but let's do the proposal and see if this is possible!

@wenfangdu
Copy link
Author

Evan, what do you think? @yyx990803

@klef-dev
Copy link

Looking at it, is there any language currently using this proposed color code #41b883 on github?

@wenfangdu
Copy link
Author

@klefcodes Nope.

@posva
Copy link
Member

posva commented May 3, 2021

Thanks @wenfangdu !

@posva posva closed this as completed May 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants