Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition gets interrupted on beforeLeave stage when setting value in the callback. #2961

Closed
jw-foss opened this issue Jan 7, 2021 · 6 comments

Comments

@jw-foss
Copy link

jw-foss commented Jan 7, 2021

Version

3.0.5

Reproduction link

https://codesandbox.io/s/transition-bug-report-bxh3n?file=/src/App.vue

Steps to reproduce

  1. Open the link https://codesandbox.io/s/transition-bug-report-bxh3n?file=/src/App.vue
  2. Click on the button wait until element gets rendered
  3. Click on the non-white backdrop, then observe.
  4. Uncomment line 24 "counter.value ;"
  5. Repeat step 2 - 3.
    Or

Same steps 1. 2. 3 like above.
4 Remove the part in line 5 " {{ counter }}"
5. Repeat step 2 - 3.

What is expected?

Expecting the transition gets resolved normally

What is actually happening?

The transition gets interrupted by setting the transition's first child display value none before transition ends.

@jw-foss
Copy link
Author

jw-foss commented Jan 7, 2021

BTW:
Worked in 3.0.3 after 3.0.4 it's broken.

@edison1105
Copy link
Member

I think it's dumplicate of #2757

@jw-foss
Copy link
Author

jw-foss commented Jan 7, 2021

True, it's the same issue.

@jw-foss
Copy link
Author

jw-foss commented Jan 7, 2021

After I took a look at the issue #2757 , I went to inspect code for vShow and added a debugger for update method, I found that update gets called 3 times for a single call (maybe because the update for the component children triggered the following call).

@posva
Copy link
Member

posva commented Jan 7, 2021

Duplicate of #2757

@posva posva marked this as a duplicate of #2757 Jan 7, 2021
@posva posva closed this as completed Jan 7, 2021
@jw-foss
Copy link
Author

jw-foss commented Jan 7, 2021

@posva I understand that this is duplicated, but this bug is considered p4 - important right? I dunno how you guys manages the priority, but IMHO this bug can be critical though. We all know 3.0.3 worked fine but 3.0.3 has bugs as well...

@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants