Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): handle shallow reactive arrays in renderList correctly #11870

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Sep 9, 2024

close #11869

Copy link

github-actions bot commented Sep 9, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+14 B) 37.7 kB (+6 B) 34 kB (-6 B)
vue.global.prod.js 159 kB (+14 B) 57.7 kB (+9 B) 51.3 kB (+43 B)

Usages

Name Size Gzip Brotli
createApp 55.4 kB 21.3 kB 19.4 kB
createSSRApp 59.3 kB 23 kB 20.9 kB
defineCustomElement 60.1 kB 22.8 kB 20.7 kB
overall 69.1 kB 26.4 kB 23.9 kB

Copy link

pkg-pr-new bot commented Sep 9, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11870

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11870

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11870

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11870

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11870

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11870

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11870

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11870

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11870

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11870

vue

pnpm add https://pkg.pr.new/vue@11870

commit: f571f71

@edison1105
Copy link
Member

/ecosystem-ci run

@edison1105 edison1105 added ready to merge The PR is ready to be merged. ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Sep 9, 2024
@vue-bot
Copy link
Contributor

vue-bot commented Sep 9, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

test: update test
@edison1105
Copy link
Member

/ecosystem-ci run language-tools

@vue-bot
Copy link
Contributor

vue-bot commented Sep 10, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure

@yyx990803 yyx990803 merged commit ced59ab into vuejs:main Sep 10, 2024
13 checks passed
@jh-leong jh-leong deleted the fix/renderList branch September 11, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use v-for rendering a shallowReactive array, array item incorrectly converted to a reactive object
4 participants