-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types(runtime-core): using intersection type in Readonly<...>
breaks JSDoc emit
#11799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsoncodehk
changed the title
types(runtime-core): using intersection type in
types(runtime-core): using intersection type in Sep 3, 2024
Readonly<>
breaks JSDoc emitReadonly<...>
breaks JSDoc emit
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/shared
@vue/server-renderer
@vue/compat
vue
commit: |
johnsoncodehk
added a commit
to vuejs/language-tools
that referenced
this pull request
Sep 3, 2024
2 tasks
edison1105
approved these changes
Sep 4, 2024
edison1105
added
ready to merge
The PR is ready to be merged.
scope: types
❗ p4-important
Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
regression
and removed
regression
labels
Sep 4, 2024
3 tasks
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
There seems to be a type breakage in vue-18n ecosystem-ci but I don't think we should block the PR on it. Would still be great to investigate though: https://github.com/vuejs/ecosystem-ci/actions/runs/10701509209/job/29667629360 /cc @kazupon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
❗ p4-important
Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
ready to merge
The PR is ready to be merged.
scope: types
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a dts emit regression for v3.5.
Input Component
v3.5.0 emit dts result
PR emit dts result