Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Teleport): ensure targetAnchor and targetStart not null during hydration #11456

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jul 30, 2024

close #11400

Copy link

github-actions bot commented Jul 30, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90 kB (+121 B) 34.5 kB (+68 B) 31.1 kB (+50 B)
vue.global.prod.js 147 kB (+121 B) 54 kB (+58 B) 48 kB (+30 B)

Usages

Name Size Gzip Brotli
createApp 49.6 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 20.9 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB
overall 63.1 kB 24.5 kB 22.3 kB

@edison1105 edison1105 marked this pull request as draft July 30, 2024 01:41
@edison1105 edison1105 changed the title fix(Teleport): ensure targetAnchor not null during hydration fix(Teleport): ensure targetAnchor and targetStart not null during hydration Jul 30, 2024
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jul 30, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue failure success
vitepress success success
vue-i18n failure failure
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 marked this pull request as ready for review July 30, 2024 02:59
@yyx990803
Copy link
Member

Ecosystem CI failures do not seem to be related to this PR.

@yyx990803 yyx990803 merged commit 12667da into vuejs:main Jul 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

throw TypeError when unmounting Teleport after hydration
3 participants