-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-core): ensure suspense content inherit scopeId #10652
Conversation
Size ReportBundles
Usages
|
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
@edison1105 Sorry for pinging you again. May we have this PR labeled as "ready to review" to attract a bit more of attention by potential reviewers now that we're starting with the v3.5.z cycle? The original issue has been open for 3 years and it's labeled as priority 4, so definitely this PR is worth it! |
@yyx990803 Sorry for the ping, but can we get a review on this to hopefully have this in before 3.5.0 stable? As stated above, Suspense has long-standing issues with Transition for years and this is a simple fix that will get it finally resolved. |
@yyx990803 Thank you very much!! 🚀🚀🚀🚀 @edison1105 Thank you very much as well for your energy for doing fixes so quick! |
Vue 3.5 fixed the issue where Suspense didn't inherit correctly the scope id. See vuejs/core/pull/10652
Vue 3.5 fixed the issue where Suspense didn't inherit correctly the scope id. See vuejs/core/pull/10652
close #5148