Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(hydration): supports tree shaking of code in dev environments. #10326

Closed
wants to merge 1 commit into from
Closed

perf(hydration): supports tree shaking of code in dev environments. #10326

wants to merge 1 commit into from

Conversation

yangxiuxiu1115
Copy link
Contributor

@yangxiuxiu1115 yangxiuxiu1115 commented Feb 12, 2024 •
edited
Loading

supports tree shaking of code in dev environments.

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.4 kB 34.4 kB 31 kB
vue.global.prod.js 148 kB 53.7 kB 47.9 kB

Usages

Name Size Gzip Brotli
createApp 50.5 kB 19.7 kB 18 kB
createSSRApp 53.8 kB 21.1 kB 19.3 kB
defineCustomElement 52.8 kB 20.5 kB 18.7 kB
overall 64.2 kB 24.8 kB 22.5 kB

@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as draft February 12, 2024 08:32
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as ready for review February 12, 2024 08:33
@yyx990803
Copy link
Member

This doesn't seem necessary - when __DEV__ is false most bundlers can already treeshake the function call after it.

@yangxiuxiu1115 yangxiuxiu1115 deleted the perf/hydration branch February 13, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangxiuxiu1115 @yyx990803