fix: avoid track unrelated effects

vuejs · Apr 5, 2023 · 30a2d61 · 30a2d61
1 parent 82eaeae
commit 30a2d61
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/packages/reactivity/src/computed.ts b/packages/reactivity/src/computed.ts
@@ -1,4 +1,9 @@
-import { DebuggerOptions, ReactiveEffect } from './effect'
+import {
+  DebuggerOptions,
+  pauseTracking,
+  ReactiveEffect,
+  resetTracking
+} from './effect'
 import { Ref, trackRefValue, triggerRefValue } from './ref'
 import { hasChanged, isFunction, NOOP } from '@vue/shared'
 import { ReactiveFlags, toRaw } from './reactive'
@@ -65,19 +70,21 @@ export class ComputedRefImpl<T> {
   get value() {
     // the computed ref may get wrapped by other proxies e.g. readonly() #3376
     const self = toRaw(this)
-    if (!self._dirty) {
+    if (!self._dirty && self._computedsToAskDirty.length) {
+      pauseTracking()
       for (const computedToAskDirty of self._computedsToAskDirty) {
         computedToAskDirty.value
         if (self._dirty) {
           break
         }
       }
+      resetTracking()
     }
     trackRefValue(self)
     if (self._dirty || !self._cacheable) {
       const newValue = self.effect.run()!
       if (hasChanged(self._value, newValue)) {
-        triggerRefValue(this, undefined)
+        triggerRefValue(self, undefined)
       }
       self._value = newValue
       self._dirty = false