-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionalDependencies are installed as normal dependencies #96
Comments
Also see this excerpt from readme:
Does it mean that it's not intentional to have |
I have created a project including eslint+prettier with vue-cli and was a bit confused that after updating prettier to v2, there was still an instance of prettier v1 installed as a dependency of |
@sodatea could you take a look at this? It increases my node_module size by around 8mb. So given that I have around 100 projects. installed where component-compiler-utils is a dependency it is around 1 gigabyte of harddrive space that is wasted. |
this also brakes prettier-atom's behaviour |
This package declares
prettier
inoptionalDependencies
:component-compiler-utils/package.json
Lines 68 to 70 in 8b0da74
I'm not sure if that was the intention, but when this
@vue/component-compiler-utils
is a dependency (or sub-dependency) in a given project, thatoptionalDependencies
will be installed. And it's kinda pointless and unwanted to installprettier
in my projects where I don't use it, I feel.I know that I can use
npm i --no-optional
but that's a poor solution as nobody remembers to use it.Also, I understand that it might not be desired to have
prettier
inpeerDependencies
as then it will trigger a warning when not installed.Maybe just mention in the documentation that if you want to use prettier you have to add it manually?
The text was updated successfully, but these errors were encountered: