From 7de2d02c3a666e79478aac901df9e50e056d519f Mon Sep 17 00:00:00 2001 From: Robson Oliveira Date: Wed, 9 Nov 2022 21:01:38 -0300 Subject: [PATCH] refactor(search-input): rename variables and remove unnecessary ESLint rule disable --- src/components/header/index.tsx | 1 - src/components/search-input/functions.ts | 2 +- src/components/search-input/index.tsx | 26 +++++++------------ ...{results-component.tsx => results-box.tsx} | 10 +++---- 4 files changed, 16 insertions(+), 23 deletions(-) rename src/components/search-input/{results-component.tsx => results-box.tsx} (91%) diff --git a/src/components/header/index.tsx b/src/components/header/index.tsx index 8797f7c66..138cae09a 100644 --- a/src/components/header/index.tsx +++ b/src/components/header/index.tsx @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/no-unused-vars */ import { Header as HeaderBrand, Link as VtexLink, diff --git a/src/components/search-input/functions.ts b/src/components/search-input/functions.ts index a742b729e..ed7df66a8 100644 --- a/src/components/search-input/functions.ts +++ b/src/components/search-input/functions.ts @@ -1,6 +1,6 @@ import { Hit } from 'react-instantsearch-core' -export const breadcrumbs = (hit: Hit) => { +export const getBreadcrumbs = (hit: Hit) => { const urlSplit = hit.url.split('/').slice(5) const endpointSplit = urlSplit.map((e) => e.split('#')) return endpointSplit.flat() diff --git a/src/components/search-input/index.tsx b/src/components/search-input/index.tsx index db00ed392..f54df2688 100644 --- a/src/components/search-input/index.tsx +++ b/src/components/search-input/index.tsx @@ -1,9 +1,8 @@ -/* eslint-disable @typescript-eslint/no-explicit-any */ import algoliasearch from 'algoliasearch/lite' import { InstantSearch } from 'react-instantsearch-dom' import SearchBox from './search-box' -import Results from './results-component' +import Results from './results-box' import { Box } from '@vtex/brand-ui' import { useRef, useState } from 'react' import useClickOutside from 'utils/hooks/useClickOutside' @@ -20,19 +19,14 @@ export default function SearchInput() { const resultsBox = useRef() useClickOutside(resultsBox, setfocusOut) return ( - <> - - setfocusOut({ modaltoggle: true })} - ref={resultsBox} - > - - {focusOut.modaltoggle && } - - - + + setfocusOut({ modaltoggle: true })} ref={resultsBox}> + + {focusOut.modaltoggle && } + + ) } diff --git a/src/components/search-input/results-component.tsx b/src/components/search-input/results-box.tsx similarity index 91% rename from src/components/search-input/results-component.tsx rename to src/components/search-input/results-box.tsx index 7c3378dc7..2f961f25a 100644 --- a/src/components/search-input/results-component.tsx +++ b/src/components/search-input/results-box.tsx @@ -6,7 +6,7 @@ import { Hit, SearchState } from 'react-instantsearch-core' import { Box, Flex, IconCaret, Text } from '@vtex/brand-ui' import { getIcon } from 'utils/constants' -import { breadcrumbs } from './functions' +import { getBreadcrumbs } from './functions' import styles from './styles' interface HitProps { @@ -15,7 +15,7 @@ interface HitProps { } const Hit = ({ hit, setSearchStateActive }: HitProps) => { - const breadCrumbs = breadcrumbs(hit) + const breadcrumbsList = getBreadcrumbs(hit) const DocIcon = getIcon(hit.doctype) @@ -31,13 +31,13 @@ const Hit = ({ hit, setSearchStateActive }: HitProps) => { {`In ${hit.doctype}`} - {breadCrumbs.length > 0 && ( + {breadcrumbsList.length > 0 && ( )} - {breadCrumbs.map((filter: string, index: number) => ( + {breadcrumbsList.map((filter: string, index: number) => ( {filter} - {index < breadCrumbs.length - 1 ? ( + {index < breadcrumbsList.length - 1 ? ( ) : null}