Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for the Tabs component #1115

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Tests for the Tabs component #1115

merged 2 commits into from
Mar 31, 2020

Conversation

igorbrasileiro
Copy link

What is the purpose of this pull request?

as the title says

What problem is this solving?

Related issue #1083

How should this be manually tested?

yarn test

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@igorbrasileiro igorbrasileiro requested a review from a team as a code owner March 24, 2020 00:14
@igorbrasileiro igorbrasileiro self-assigned this Mar 24, 2020
klzns
klzns suggested changes Mar 24, 2020
View reviewed changes
react/components/Tabs/index.test.tsx Outdated Show resolved Hide resolved
@igorbrasileiro igorbrasileiro requested a review from klzns March 24, 2020 13:30
klzns
klzns previously approved these changes Mar 24, 2020
View reviewed changes
matheusps
matheusps previously approved these changes Mar 24, 2020
View reviewed changes
@emersonlaurentino emersonlaurentino dismissed stale reviews from matheusps, klzns, and themself via abddc1f March 31, 2020 14:35
@emersonlaurentino emersonlaurentino merged commit 9c29a58 into features Mar 31, 2020
@emersonlaurentino emersonlaurentino deleted the feature/tabs-tests branch March 31, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonlaurentino emersonlaurentino emersonlaurentino approved these changes

@matheusps matheusps matheusps left review comments

@klzns klzns klzns left review comments

Assignees

@igorbrasileiro igorbrasileiro

Labels
✨ Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igorbrasileiro @klzns @matheusps @emersonlaurentino