Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack Overflow in Java regex with spaces in URLs while parsing large embedded image links #364

Closed
vsch opened this issue Sep 3, 2019 · 2 comments
Closed

Stack Overflow in Java regex with spaces in URLs while parsing large embedded image links #364

vsch opened this issue Sep 3, 2019 · 2 comments
Labels
🪲 bug 🎉 fixed
Milestone
V 0.50.40

Comments

@vsch
Copy link
Owner

vsch commented Sep 3, 2019 •
edited
Loading

  • Stack overflow when parsing large embedded images with space in URL enabled.
@vsch
Copy link
Owner Author

vsch commented Sep 3, 2019

Now link urls starting with data:image/png;base64, do not allow spaces in the link. A kludge, but solves the problem for the moment.

@vsch vsch modified the milestone: V 0.50.34 Sep 3, 2019
@vsch vsch added this to the V 0.50.38 milestone Sep 5, 2019
@vsch
Copy link
Owner Author

vsch commented Sep 5, 2019

Fixed by implementing a non-regex parser for link destination URLs. Otherwise long non-image links would also cause stack overflow.

@vsch vsch closed this as completed Sep 5, 2019
@vsch vsch modified the milestones: V 0.50.38, V 0.50.40 Sep 10, 2019
@mrombout mrombout mentioned this issue Dec 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug 🎉 fixed
Projects
None yet
Milestone
V 0.50.40
Development

No branches or pull requests
1 participant
@vsch