getLineNumber incorrect with Windows end of line separators

[mattmook]

Document.getLineNumber assumes the end-of-line character is just one character wide and so on Windows Lin numbers are, effectively, doubled.

To Reproduce

Given the following we would expect the line number for the 7th character ('W') to return 1, however it returns 2:

Document document = new Document(new MutableDataSet(), BasedSequenceImpl.of("Hello\r\nWorld"));

document.getLineNumber(7) // should return 1

Additional context

I have created the PR #339 to fix this issue

[vsch]

@mattmook, thank you for the PR and the report. I'll merge and release shortly.

[vsch]

@mattmook, I only changed the code to not treat offset between \r\n as part of the next line. So only offsets after complete EOL reflect next line number.

Fix for this is available. Repo updated, maven updated but may take a while to show up in maven central.

[mattmook]

Cool, many thanks