Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.4 is broken due to missing readme #18

Closed
coilysiren opened this issue Mar 4, 2019 · 6 comments
Closed

Release 1.3.4 is broken due to missing readme #18

coilysiren opened this issue Mar 4, 2019 · 6 comments

Comments

@coilysiren
Copy link

The README.md isn't included in the python package, so this change e674b74#diff-2eeaed663bd0d25b7e608891384b7298 breaks installs of version 1.3.4

@vrcmarcos vrcmarcos reopened this Mar 6, 2019
@vrcmarcos
Copy link
Owner

Thanks for point it!

Could you check if PR #19 fixed it, please?

@infinite-Joy9l
Copy link

I am still getting the issue. :(

@tdhopper
Copy link

tdhopper commented Mar 11, 2019

.
├── elasticmock
│  ├── __init__.py
│  ├── fake_elasticsearch.py
│  └── utilities
│     └── __init__.py
├── ElasticMock.egg-info
│  ├── dependency_links.txt
│  ├── PKG-INFO
│  ├── requires.txt
│  ├── SOURCES.txt
│  └── top_level.txt
├── PKG-INFO
├── setup.cfg
├── setup.py
└── tests
   ├── __init__.py
   └── test_elasticmock.py
Looking in indexes: https://pypi.org/simple, https://artifacts.d.cylance.com/api/pypi/datsci-pypi/simple
Collecting elasticmock
  Downloading https://files.pythonhosted.org/packages/ee/27/d70e1ca53b8080138f613e4d600831397acd6bf7fdc466bea32692fc9bf5/ElasticMock-1.3.5.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/mg/9dh5w1r93w3630s4p0y33_c40000gn/T/pip-install-8jE_6k/elasticmock/setup.py", line 10, in <module>
        with open(path.join(this_directory, 'README.md'), 'r') as f:
    IOError: [Errno 2] No such file or directory: '/private/var/folders/mg/9dh5w1r93w3630s4p0y33_c40000gn/T/pip-install-8jE_6k/elasticmock/README.md'

@tdhopper
Copy link

Opened #20 to fix.

@vrcmarcos
Copy link
Owner

Just merged @tdhopper PR. Could you check if now it's fixed, please?

@tdhopper
Copy link

Seems okay to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants