Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include packages from other vpm repository #23

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

anatawa12
Copy link
Contributor

Closes #21

PackageBuilder/Build.cs Outdated Show resolved Hide resolved
@Spokeek
Copy link

Spokeek commented Nov 10, 2023

I have a thought about this, as we base ourselves on package ids, those can have some vpm dependencies.

Do we want to track and automatically add those dependencies as well ?

Spokeek added a commit to Spokeek/vpm-repository that referenced this pull request Nov 10, 2023
@Spokeek
Copy link

Spokeek commented Nov 10, 2023

Also, after taking time to try, it works great, but i would add some debug logs to follow what we have for other packages.

As an example, when fetching a package from github, we receive the next two logs

  17:30:14 [INF] Looking at https://github.com/Spokeek/goloco/releases/download/1.7.91/gogoloco-1.7.91.zip
  17:30:14 [INF] Found gogoloco (gogoloco) 1.7.91, adding to listing.

As we already have the 17:30:29 [INF] Downloading from vpm repository at the begining, maybe add logs to confirm when we actually add the manifests.

For the rest, it's all good to me.

@anatawa12
Copy link
Contributor Author

anatawa12 commented Nov 13, 2023

Do we want to track and automatically add those dependencies as well ?

I think no. I think it's good to have some check and exclusion (or error) for missing dependencies in the repository but I don't think including packages non explicitly is not good.

maybe add logs to confirm when we actually add the manifests.

I think it's good. I'll add that.

PackageBuilder/Build.cs Outdated Show resolved Hide resolved
PackageBuilder/Build.cs Outdated Show resolved Hide resolved
Copy link

@Spokeek Spokeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, after all my digging and checked on my own repo, this seem to work as expected, it's all good for me (if that mattered, hehe).

Great job.

Spokeek added a commit to Spokeek/package-list-action that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pick some packages from other vpm repository
2 participants