-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include packages from other vpm repository #23
base: main
Are you sure you want to change the base?
Conversation
I have a thought about this, as we base ourselves on package ids, those can have some vpm dependencies. Do we want to track and automatically add those dependencies as well ? |
based on implementation of vrchat-community/package-list-action#23
Also, after taking time to try, it works great, but i would add some debug logs to follow what we have for other packages. As an example, when fetching a package from github, we receive the next two logs
As we already have the For the rest, it's all good to me. |
I think no. I think it's good to have some check and exclusion (or error) for missing dependencies in the repository but I don't think including packages non explicitly is not good.
I think it's good. I'll add that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, after all my digging and checked on my own repo, this seem to work as expected, it's all good for me (if that mattered, hehe).
Great job.
Closes #21