-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle deprecated package id #20
Comments
Sure, you're welcome to modify this action to fit your needs! |
I'm doing so at the moment. I'm technically taking another direction by allowing to list some remove vpm listing to integrate in mine so you could add packages, github repos, and vpm listings. My point was also to see if there was an expected behavior when loading packages that have releases linking multiple ids. If you have information about that @momo-the-monster i would be glad making changes or a PR to reflect the thing. |
We don't have any mechanisms in the core library for identifying a package which changed its id - the id is used as the core identifier for the package and is seen as a separate entity. |
All right, i'll look to make a id collision based on a repositoryUrl so if the package id of the release is different than the latest id of the repository, i'll ignore it. |
Sounds good! |
All right, PR ready, hopefully stays in the workflow. That's a little slow process as it pulls the manifests one at the time, i don't know if that's a concern. |
@momo-the-monster any news on potential community PR integration ? |
I am having an edge case where I (think) I need to ignore some package id from a listing i have.
I'm having a vpm listing setup and i'm importing a github repository with the githubRepos option.
The issue i have is that within the release history of that package, there is two different ids listed.
The package i have an issue with is https://github.com/bdunderscore/modular-avatar
Before version 1.0.0, they have used the id "net.fushizen.modular-avatar" and now are using "nadena.dev.modular-avatar"
By that mean, the action is creating two separate entries for the package.
I guess some solutions would be to either be the following
- be able to ignore some entries by filtering some id- be able to merge some id- change the original package form to list previously used ids so we can merge their definitionCan i have your thoughts about this ?Edit:
After discussion, i made a PR that will update the github repository fetch mechanism.
Now we filter the list of release by the latest release manifest package id.
If the other releases don't have the same package id, they are filtered.
The text was updated successfully, but these errors were encountered: