Fix things with a few params #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
The previous implementation meant it wasnt allowed to be set
Happyrobot33
changed the title
|
I think it's better to have configurable name than configurable suffix. |
|
Agreed, i would be more into customizing the list name as a whole instead of changing prefixes and suffixes. |
|
Also, maybe change the PR name to something like "Make Package Listing Name configurable" ? |
manually merge in this PR to fix my runners vrchat-community#28
|
Closing to make a new PR with just these changes using a new branch on my fork |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a suffix to the package listing
Fixed the ability to set CurrentListingUrl to another URL. I needed to fix this in order for my custom domain to work
closes #15