Fix precedences for interpreted functions #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re lots of things to avoid such bugs in the future
quickbeam123
approved these changes
Feb 5, 2025
|
The tests did not give any further violation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has already been fixed, but the fix must have got lost in some merge, so now I added a unit test, which is not much but better than nothing.
The bug could be reproduced by comparing the two terms in both directions which gives inconsistent results, so I suggest a debug check for this. For now I added this to forward demodulation since we are comparing pairs of terms there anyways, but I am open to putting it somewhere else.
I will run the entire TPTP with this check to see if there's any more such bugs.