avoid sortedness errors with polymorphically let-bound constants #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mezpusz
reviewed
Apr 10, 2024
MichaelRawson
force-pushed
the
michael-sorthelper-let
branch
from
215a508 to
9c6400d
Compare
|
A completely different solution, should be ready for re-review. Thanks @mezpusz ! |
mezpusz
approved these changes
May 16, 2024
quickbeam123
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug 1 of #542 by providing a fast path for constants in
getResultSortthat also does not assert a condition that isn't true for let-bound constants.A TFX1
$letmight capture sort variables. Consider e.g. polymorphic lists and the following axiom.In the expression
e,x: list(A). But this is a non-polymorphic constant (both term and type arity 0) with a variable in its result sort, whichSortHelperdoesn't like. It seems to be eliminated just fine in later FOOLing around.