Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to take notes on players #178

Open
justpokerdev opened this issue Nov 11, 2020 · 2 comments
Open

Add feature to take notes on players #178

justpokerdev opened this issue Nov 11, 2020 · 2 comments
Labels
feature good first issue Good for newcomers

Comments

@justpokerdev
Copy link
Collaborator

justpokerdev commented Nov 11, 2020

Some poker apps allow you to takes notes on players at your table. It would be good to add this functionality to JP.

Player Menu Screenshot

There could be an additonal entry in the player menu (shown above) "Notes", that when clicked opens up a movable text box (shouldn't cover entire screen and shouldn't stop you from interacting with the rest of the app), where you can add text.

Text box should also include "Save" and "Cancel" buttons to either commit or discard changes.

Notes are private, and only the player taking the notes them should ever be able to see them. Notes should persist after a browser refresh (need to be stored in backend as well).

@gborodulin
Copy link

I will add this feature

@justpokerdev
Copy link
Collaborator Author

You should also be able to view/take notes on multiple players at the same time, and resize the text area. The text area should be semi transparent, with an opaque border. I'm also thinking a little "X" at the top right to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants