Implement puppet-metadata with various subcommands #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
implement-commands
branch
from
d633196 to
f1b04bb
Compare
This implements a puppet-metadata executable which now only implements the eol command to show which operating systems in metadata are end of life.
ekohl
force-pushed
the
implement-commands
branch
from
f1b04bb to
ab4cffe
Compare
bastelfreak
approved these changes
Mar 9, 2024
bastelfreak
reviewed
Mar 11, 2024
| end | ||
|
|
||
| def self.commands | ||
| subclasses.to_h { |subclass| [subclass.command, subclass] } |
There was a problem hiding this comment.
subclasses is an undefined variable:
$ bundle exec puppet-metadata
bundler: failed to load command: puppet-metadata (/home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/bin/puppet-metadata)
/home/bastelfreak/code/puppet_metadata/bin/puppet-metadata:23:in `commands': undefined local variable or method `subclasses' for BaseCommand:Class (NameError)
Did you mean? superclass
from /home/bastelfreak/code/puppet_metadata/bin/puppet-metadata:59:in `main'
from /home/bastelfreak/code/puppet_metadata/bin/puppet-metadata:68:in `<top (required)>'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/bin/puppet-metadata:25:in `load'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/bin/puppet-metadata:25:in `<top (required)>'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/cli/exec.rb:58:in `load'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/cli/exec.rb:58:in `kernel_load'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/cli/exec.rb:23:in `run'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/cli.rb:491:in `exec'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/cli.rb:34:in `dispatch'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/cli.rb:28:in `start'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/exe/bundle:45:in `block in <top (required)>'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
from /home/bastelfreak/code/puppet_metadata/.vendor/ruby/3.0.0/gems/bundler-2.4.1/exe/bundle:33:in `<top (required)>'
from /usr/bin/bundle:25:in `load'
from /usr/bin/bundle:25:in `<main>'
There was a problem hiding this comment.
I think I read somewhere that subclasses was a newer Ruby feature. I guess that isn't in 3.0 yet.
There was a problem hiding this comment.
I tested around and it works with Ruby 3.1
There was a problem hiding this comment.
I'll figure out if there's a nice solution. I'd like to avoid making part of the codebase Ruby 3.1+ but the rest 2.7+.
bastelfreak
reviewed
Mar 11, 2024
| PuppetMetadata.read(@filename) | ||
| end | ||
| rescue StandardError => e | ||
| warn "Failed to read #{filename}: #{e}" |
There was a problem hiding this comment.
Suggested change
| warn "Failed to read #{filename}: #{e}" | |
| warn "Failed to read #{@filename}: #{e}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a puppet-metadata executable which now only implements the eol command to show which operating systems in metadata are end of life.