Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wg quick as another provider for interfaces #54

Merged
merged 12 commits into from
Aug 11, 2022
Merged

Add wg quick as another provider for interfaces #54

merged 12 commits into from
Aug 11, 2022

Conversation

sebastianrakel
Copy link
Member

Sometimes i want to connect to a vpn on demand, so i want to use wg quick and now this module can generate wg quick config

@sebastianrakel sebastianrakel force-pushed the f-providers branch 3 times, most recently from cb75cfb to 52eeb0c Compare August 7, 2022 18:20
@sebastianrakel sebastianrakel changed the title Add wg quick as another provider for interfaces WIP: Add wg quick as another provider for interfaces Aug 7, 2022
@sebastianrakel sebastianrakel marked this pull request as draft August 7, 2022 18:36
@sebastianrakel sebastianrakel force-pushed the f-providers branch 4 times, most recently from e8b279e to d8d5d08 Compare August 7, 2022 20:44
@sebastianrakel sebastianrakel force-pushed the f-providers branch 2 times, most recently from 8332567 to eb9804e Compare August 7, 2022 21:10
@sebastianrakel sebastianrakel marked this pull request as ready for review August 7, 2022 21:15
@sebastianrakel sebastianrakel changed the title WIP: Add wg quick as another provider for interfaces Add wg quick as another provider for interfaces Aug 7, 2022
smortex
smortex requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor problems and I think a major one that prevent multiple interfaces with the same provider to be used simultaneously.

manifests/interface.pp Outdated Show resolved Hide resolved
manifests/interface.pp Outdated Show resolved Hide resolved
manifests/interface.pp Outdated Show resolved Hide resolved
manifests/provider/systemd.pp Outdated Show resolved Hide resolved
manifests/provider/wgquick.pp Outdated Show resolved Hide resolved
spec/acceptance/init_spec.rb Show resolved Hide resolved
templates/wireguard_conf.epp Outdated Show resolved Hide resolved
@sebastianrakel sebastianrakel force-pushed the f-providers branch 3 times, most recently from ad45483 to 1508a55 Compare August 8, 2022 09:21
bastelfreak
bastelfreak reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. but we should merge #51 first

@bastelfreak bastelfreak added the enhancement New feature or request label Aug 8, 2022
smortex
smortex reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few lasts points that might deserve consideration before merging.

manifests/provider/systemd.pp Outdated Show resolved Hide resolved
manifests/provider/wgquick.pp Outdated Show resolved Hide resolved
manifests/interface.pp Outdated Show resolved Hide resolved
@sebastianrakel sebastianrakel requested a review from smortex August 11, 2022 06:43
@bastelfreak bastelfreak merged commit e832df6 into voxpupuli:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@smortex smortex Awaiting requested review from smortex

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianrakel @smortex @bastelfreak