Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rvm::passenger::apache not loading correct mod_passenger.so module on Debian #18

Closed
cure opened this issue Jan 19, 2014 · 7 comments
Closed

Comments

@cure
Copy link

cure commented Jan 19, 2014

Basically, lib_path needs to be modified in apache::mod::passenger. That module has logic to do the right thing on FreeBSD:

if $::osfamily == 'FreeBSD' {
apache::mod { 'passenger':
lib_path => "${passenger_root}/buildout/apache2"
}
} else {
apache::mod { 'passenger': }
}

but for all other types of systems, lib_path is left alone. That's all good and well if you don't rebuild passenger via rvm::passenger::apache. But if you do (by specifying a $version), you really want to have lib_path set as in the FreeBSD case so that the

mods-available/passenger.load

file ends up pointing at the new mod_passenger.so file.

I'm not sure how to fix that from

rvm/manifests/passenger/apache.pp

Can that be done?

@carlossg
Copy link
Member

I don't use the apache module myself, but looks like they would have to add an option to pass lib_path and use that from here

@jonoterc
Copy link

FYI, I've got a pending PR witgh puppetlabs/puppetlabs-apache to address that: puppetlabs/puppetlabs-apache#558

Once that's been accepted I'll submit a PR here to enable integration

@jonoterc
Copy link

jonoterc commented Feb 4, 2014

Follow-up on my earlier message; I submitted a replacement PR to puppetlabs/puppetlabs-apache on this issue: puppetlabs/puppetlabs-apache#607 ; my corresponding fork can be found here: https://github.com/jonoterc/puppetlabs-apache/tree/mod-passenger

I've also patched a fork of this repo to integrate with that patch: https://github.com/jonoterc/puppet-rvm/tree/mod-passenger - (passes spec:system tests on ubuntu 12.04 and centos-64).

I'll be submitting a PR to this repo if/when the puppetlabs/puppet-apache patch is accepted, so if you try out the fork let me know if you encounter any issues.

@nessur
Copy link

nessur commented Mar 28, 2014

thank you! can't wait for puppetlabs-apache to accept that pull request.

@jonoterc
Copy link

puppetlabs/apache just accepted (an updated version of) my PR; I'll be submitting an updated PR here soon

@jonoterc
Copy link

jonoterc commented Apr 1, 2014

I've brought my fork up-to-date, but will hold off on submitting a PR until the puppetlabs-apache updates are published to the forge (my fork currently references the github repo, which isn't very desirable).

@carlossg
Copy link
Member

Fixed in #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants