Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of pip3.4 and pip3.6 #476

Closed
jsfrerot opened this issue Apr 12, 2019 · 2 comments · Fixed by #489
Closed

Allow the use of pip3.4 and pip3.6 #476

jsfrerot opened this issue Apr 12, 2019 · 2 comments · Fixed by #489

Comments

@jsfrerot
Copy link

Centos 7 doesn't install pip3 anymore, but pip3.4 or pip3.6

diff --git a/modules/python/manifests/pip.pp b/modules/python/manifests/pip.pp
index e7aa6efe2..3c8f241b9 100644
--- a/modules/python/manifests/pip.pp
+++ b/modules/python/manifests/pip.pp
@@ -75,7 +75,7 @@ define python::pip (
   $pkgname                             = $name,
   $ensure                              = present,
   $virtualenv                          = 'system',
-  Enum['pip', 'pip3'] $pip_provider    = 'pip',
+  Enum['pip','pip3','pip3.4','pip3.6'] $pip_provider    = 'pip',
   $url                                 = false,
   $owner                               = 'root',
   $group                               = 'root',
@pillarsdotnet
Copy link
Contributor

pillarsdotnet commented May 22, 2019

Probably be better to have a regex, like:

Pattern[/\Apip([2-3](\.\d)?)?\z] $pip_provider = 'pip',

@pillarsdotnet
Copy link
Contributor

I see that the current version has String[1] which will certainly allow the requested values.

@jsfrerot, would you please close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants