Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that npm is installed with collectors before using it #54

Closed
carlossg opened this issue Oct 14, 2013 · 3 comments
Closed

Enforce that npm is installed with collectors before using it #54

carlossg opened this issue Oct 14, 2013 · 3 comments

Comments

@carlossg
Copy link
Member

A package with provider => npm may run before npm is installed and fail

Not sure if it is ok to add it in the module, but at least should be in the README

if $::operatingsystem != 'ubuntu' {
Package['npm'] -> Package <| provider == npm |>
} else {
Package['nodejs'] -> Package <| provider == npm |>
}

An nodejs::npm anchor would also simplify the rule above

Does it look reasonable?

@jamescarr
Copy link

👍 this really caused me some headaches today!

@Twipped
Copy link

Twipped commented Dec 15, 2013

This looks to be the source of #57

Edit: Confirmed, added the above code to line 83 of init.pp and my dependency issue went away.

@juniorsysadmin
Copy link
Member

Should no longer be occurring. Note that we also use require => Class['nodejs'] in the npm defined type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants