Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP->HTTPS #818

Closed
dowlingw opened this issue Jun 15, 2016 · 3 comments
Closed

HTTP->HTTPS #818

dowlingw opened this issue Jun 15, 2016 · 3 comments
Labels
enhancement New feature or request

Comments

@dowlingw
Copy link

Feature request: Add a https_redirect option to the vhost type that will:

  • Implies ssl_only for the default location
  • Installs an additional location with ssl => false that performs a temporary or permanent HTTP redirect to the same URL at HTTPS.

This will significantly reduce the amount of boilerplate resources required to do HTTPS-only sites with a friendly redirection for HTTP visitors.

I should be able to generate a PR, but will need some assistance with rspec because n00b.

@pckls
Copy link

pckls commented Jun 15, 2016

Happy to assist with the testing :)

@3flex 3flex added the enhancement New feature or request label Jul 4, 2016
@wyardley
Copy link
Collaborator

I think $rewrite_to_https does this, though it would be easier to find if it had 'ssl' in the parameter name and / or was grouped with the SSL related parameters. Can you see if that works for you?

@wyardley
Copy link
Collaborator

Feature already exists, though do want to support setting the redirect port, and possibly rename the config option to be more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants