Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastcgi_params should not be creating non-standard files by default #682

Closed
XANi opened this issue Sep 15, 2015 · 3 comments
Closed

fastcgi_params should not be creating non-standard files by default #682

XANi opened this issue Sep 15, 2015 · 3 comments

Comments

@XANi
Copy link

XANi commented Sep 15, 2015

As it is now, to have empty fastcgi_params file (if, for example, I want to completely manage it from manifest) requires explictly creating empty file, ensuring it is before every nginx invocation (which is error-prone) and then passing it as parameter.

Passing /dev/null as fastcgi_param just causes puppet to break /dev/null permissions

Passing false (which should just mean "i dont want that parameter in my config") returns validation error

@jfryman
Copy link
Contributor

jfryman commented Oct 2, 2015

Can you give me an example of what this looks like in your manifest?

Likewise, any thoughts about how to model this better are most appreciated.

@XANi
Copy link
Author

XANi commented Oct 2, 2015

I wanted to disable taking params from file and just pass a list of them in manifest (ceph's radosgw had a bug with default params and I had to turn few of them off)

so I've set up fastcgi-params file to /dev/null, then nginx module chmodded that file and, well, a lot of apps are very unhappy if they can't access /dev/null....

IMO it should either:

  • just do not add fastcgi_param config option if false is passed to it
  • do not manage permissions of that file

@wyardley
Copy link
Collaborator

This is now being tracked in #862; feel free to follow that if you want to see what ends up happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants