Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning/notice about hiera? #677

Closed
nschloe opened this issue Sep 3, 2015 · 2 comments
Closed

warning/notice about hiera? #677

nschloe opened this issue Sep 3, 2015 · 2 comments

Comments

@nschloe
Copy link

nschloe commented Sep 3, 2015

I noticed that this module recommends usage of Hiera by issuing the "warning" (it's marked as a notice in the actual output)

manifests/notice/config.pp:  $message = "[nginx] *** DEPRECATION WARNING***: HI! I notice that you're declaring some attributes in Class[nginx]. It is highly recommended to set these values via Hiera going forward. This will become mandatory in the near future. Please check out https://github.com/jfryman/puppet-nginx/blob/master/docs/hiera.md for more information."

When browsing through the sources, I couldn't find any place where puppet-nginx makes explicit use of hiera. Am I missing something?
In reality, I think it's correct that the module makes no assumptions about how and where the data is provided. That leaves the question of why puppet-nginx makes this recommendation.

@b4ldr
Copy link
Member

b4ldr commented Sep 11, 2015

Did you read the link it explains why this is been changed and also gives a recommendation on how to configure this without hiera

@nschloe
Copy link
Author

nschloe commented Sep 11, 2015

I did. I guess I was taken aback by the fact that puppet-nginx explicitly endorses a particular data model (Hiera) while in reality it shouldn't care.

In any case, if you think that this remark is invalid, feel free to close.

@jfryman jfryman closed this as completed Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants