Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage_repo is missing in nginx::config #535

Closed
PierreR opened this issue Dec 23, 2014 · 4 comments
Closed

Manage_repo is missing in nginx::config #535

PierreR opened this issue Dec 23, 2014 · 4 comments
Labels
needs-feedback Further information is requested

Comments

@PierreR
Copy link
Contributor

PierreR commented Dec 23, 2014

I am setting "manage_repo" to false like this:

class { 'nginx':
  manage_repo => false,
}

I have got a deprecation warning that encourages me to use hiera instead but nginx::config::manage_repo does not seem to exist.

Should I submit a PR to add it ?

@3flex
Copy link
Contributor

3flex commented Dec 29, 2014

@PierreR which version of the module are you using? Setting manage_repo on nginx class should not trigger a deprecation warning, and will be passed to the nginx::package class.

Is manage_repo the only parameter you're setting when you declare the nginx class?

@PierreR
Copy link
Contributor Author

PierreR commented Dec 30, 2014

I am using 0.2.1. I am following this doc : https://github.com/jfryman/puppet-nginx/blob/master/docs/hiera.md (but the recipe detailed there does not seem to work at all see #536)

@jfryman
Copy link
Contributor

jfryman commented Dec 30, 2014

I believe the depreciation warning is coming from somewhere else... because manage_repo isn't in scope there as @3flex points out... unfortunately it is a bit difficult to isolate the exact variable in code without a ton of unnecessary boilerplate for each variable in the process of being deprecated.

I wonder if this is related to attempting to set the worker_count as detailed in #536. Is that still being set somewhere (in either Hiera or in code?)

@3flex 3flex added the needs-feedback Further information is requested label Apr 13, 2015
@wyardley
Copy link
Collaborator

wyardley commented Oct 8, 2016

I'm going to close this, since it hasn't had any comments since 2014, and has not had any updates since 'needs info' was set in April of 2015.

FWIW, I haven't seen this.

@wyardley wyardley closed this as completed Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants