Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream requires nginx since 0.0.10 #458

Closed
PierreR opened this issue Sep 24, 2014 · 2 comments
Closed

Upstream requires nginx since 0.0.10 #458

PierreR opened this issue Sep 24, 2014 · 2 comments

Comments

@PierreR
Copy link
Contributor

PierreR commented Sep 24, 2014

It looks like this pr introduces a change in the way upstream can be used.

I used to let applications defined their upstream in their configuration process. Later on the nginxmodule might or might not be used.

It looks like if I define an upstream only (without vhost or include nginx) this line will fail because ${nginx::config::conf_dir} is undefined.

Is this intended ?

@3flex
Copy link
Contributor

3flex commented Sep 24, 2014

I think that was just to make config easier if the default /etc/nginx path wasn't used, and was introduced by d8e6d60.

There's no reason why you couldn't use the defined type as you described. PR welcome to add a upstream_config parameter to nginx::resource::upstream which defaults to "${nginx::config::conf_dir}/conf.d/${name}-upstream.conf". Or a more clever solution if you have one!

@3flex 3flex changed the title Upstream requires nginx since 0.10 Upstream requires nginx since 0.1.0 Oct 1, 2014
@3flex 3flex changed the title Upstream requires nginx since 0.1.0 Upstream requires nginx since 0.0.10 Oct 1, 2014
@3flex
Copy link
Contributor

3flex commented Oct 23, 2014

Closing for now due to lack of updates; will reopen on request if needed.

@3flex 3flex closed this as completed Oct 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants