puppet lint

[jameseck]

I guess my lint settings are bit draconian, but thought I'd highlight the following errors/warnings:

remote: Puppet lint failed to validate external_modules/nginx/manifests/package/debian.pp
remote: ERROR: trailing whitespace found on line 23
remote: WARNING: double quoted string containing no variables on line 51

remote: Puppet lint failed to validate external_modules/nginx/manifests/package/solaris.pp
remote: ERROR: two-space soft tabs not used on line 26
remote: ERROR: two-space soft tabs not used on line 27
remote: ERROR: trailing whitespace found on line 10
remote: WARNING: indentation of => is not properly aligned on line 27
remote: ERROR: tab character found on line 26
remote: ERROR: tab character found on line 27

remote: Puppet lint failed to validate external_modules/nginx/manifests/service.pp
remote: ERROR: trailing whitespace found on line 21

remote: Puppet lint failed to validate external_modules/nginx/tests/vhost_ssl.pp
remote: ERROR: trailing whitespace found on line 8

[3flex]

Some of those have already been fixed in master (I'm assuming you have the version of the module from the Forge?) and the rest will be taken care of by #377.

[jfryman]

v0.0.10 has been released. Is this resolved?

[3flex]

Until #377 is merged I think the following will remain:

remote: Puppet lint failed to validate external_modules/nginx/manifests/package/debian.pp
remote: WARNING: double quoted string containing no variables on line 51

Also 0.0.10 has probably introduced a few more issues that #377 will address, since the lint issues fixed there were identified in the master branch rather than 0.0.9.