Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conf.d/default.conf is being created #263

Closed
tmont opened this issue Feb 24, 2014 · 4 comments · Fixed by #285
Closed

conf.d/default.conf is being created #263

tmont opened this issue Feb 24, 2014 · 4 comments · Fixed by #285

Comments

@tmont
Copy link

tmont commented Feb 24, 2014

After installing nginx, /etc/nginx/conf.d/default is being created, and then it is being loaded by default because of include /etc/nginx/conf.d/*.conf; in nginx.conf.

Loading the default nginx virtual host doesn't seem like it should be happening by default.

example_ssl.conf is also there, but it's less harmful since it's just comments.
@seocam
Copy link
Contributor

seocam commented Feb 27, 2014

Agreed. I would just take it out.

@jfryman
Copy link
Contributor

jfryman commented Mar 28, 2014

@tmont Happy to merge a PR. 😄

@seocam seocam mentioned this issue Mar 28, 2014
Merged
@seocam
Copy link
Contributor

seocam commented Mar 28, 2014

Here it is ;)

@seocam
Copy link
Contributor

seocam commented Mar 31, 2014

@jfryman does it look ok?

@3flex 3flex mentioned this issue Jun 11, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing default.conf and example_ssl.conf TracyWebTech/puppet-nginx
3 participants
@jfryman @seocam @tmont