Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #227 breaks setting multiple options of same type with location_cfg_append/location_cfg_prepend #234

Closed
fadenb opened this issue Jan 13, 2014 · 1 comment · Fixed by #235

Comments

@fadenb
Copy link

fadenb commented Jan 13, 2014

Due to validate_hash used on $location_cfg_append and $location_cfg_prepend introduced in PR #227 it is no longer possible to pass an array.
Passing an array was often used to specify e.g. multiple rewrites. Using a hash containing the same key with different values results in only one of those to be used.

Since PR #222 is not yet merged we lost some important functionality.

@3flex
Copy link
Contributor

3flex commented Jan 13, 2014

@fadenb, sorry for that. Of course we could change that validation to permit an array, but #222 would be the better approach.

Since rspec-tests is the blocker on that PR I'll try to assist in getting that added so it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants