Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in the 'A more complex proxy example' section of README.md #1390

Closed
jflandry opened this issue Jun 8, 2020 · 2 comments
Closed

Comments

@jflandry
Copy link
Contributor

jflandry commented Jun 8, 2020

There is a stray semicolon in an example.
'localhost:3002': => { should be 'localhost:3002' => {

Affected Puppet, Ruby, OS and module versions/distributions

  • Module version: master branch

How to reproduce (e.g Puppet code you use)

puppet parser validate /tmp/typo.pp
Error: Could not parse for environment production: Syntax error at ':' (file: /tmp/typo.pp, line: 13, column: 21)

cat /tmp/typo.pp 
nginx::resource::upstream { 'puppet_rack_app':
  members => {
    'localhost:3000' => {
      server => 'localhost',
      port   => 3000,
      weight => 1,
    },
    'localhost:3001' => {
      server => 'localhost',
      port   => 3001,
      weight => 1,
    },
    'localhost:3002': => {
      server => 'localhost',
      port   => 3002,
      weight => 2,
      },
  },
}

nginx::resource::server { 'rack.puppetlabs.com':
  proxy => 'http://puppet_rack_app',
}
@ghoneycutt
Copy link
Member

Thanks for pointing this out! Could you please send a pull request. This can be done entirely through the browser - https://github.com/voxpupuli/puppet-nginx/edit/master/README.md

@jflandry
Copy link
Contributor Author

jflandry commented Jun 8, 2020

For reference: #1391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants