Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to puppetlabs-concat? #135

Closed
apenney opened this issue Sep 4, 2013 · 2 comments · Fixed by #167
Closed

Switch to puppetlabs-concat? #135

apenney opened this issue Sep 4, 2013 · 2 comments · Fixed by #167

Comments

@apenney
Copy link

apenney commented Sep 4, 2013

I was wondering if you'd accept a PR that tries to refactor some of the file handling in vhost etc to use concat::fragment rather than writing files directly into tmp dirs and building them from there.

If so I'll give it a go!

@jfryman
Copy link
Contributor

jfryman commented Sep 6, 2013

Truthfully, the concat pattern used here is unnecessary. I'd rather conf.d this sucker, and drop individual files in sites-enabled and move on with life. Care to take that on?

@apenney
Copy link
Author

apenney commented Sep 6, 2013

Probably just my lack of experience with nginx but how would that handle things like ssl, locations, etc? Don't they all need to be weaved into a single vhost.conf in the end which is where concat comes in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants