Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "udp" for "listen_port" parameter, add stream resource example into README #1019

Closed
jurim76 opened this issue Feb 14, 2017 · 4 comments
Closed

Comments

@jurim76
Copy link

jurim76 commented Feb 14, 2017

Please add "udp" option for "listen_port" parameter (need for nginx UDP load-balancer for example).
Also stream resource usage is not documented in README

stream {
  server {
    listen 514 udp;
  }
}
@wyardley
Copy link
Collaborator

I think this should probably be accomplished with a new parameter, like listen_protocol vs. trying to extend listen_port.

It shouldn't be too hard, if I get a chance, I'll try to create a PR for this. As far as docs fixes, if you have time to write up a PR (or even draft the text or post a patch), it will definitely be reviewed.

@jurim76
Copy link
Author

jurim76 commented Feb 15, 2017

@wyardley

Thank you! I've added an example patch for README.md file

README.md_patch.txt

@wyardley
Copy link
Collaborator

Actually, I started looking at implementing this, and I think listen_options will do what you want with the module as-is.
In fact, your readme seems to suggest the same thing. Can you explain why that doesn't work?

@wyardley
Copy link
Collaborator

I was thinking of a more general purpose example, but that works... I submitted #1021
I'm pretty sure listen_options is sufficient, so I'm going to close this for now -- reoopen or comment if you think there's a reason that won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants