Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use logrotate::cron instead of a broken file resource #76

Closed
wants to merge 1 commit into from
Closed

use logrotate::cron instead of a broken file resource #76

wants to merge 1 commit into from

Conversation

zeromind
Copy link

Use logrorate::cron instead of a file resource that tries to use a file that has not been around since module version 1.4.0.

This resolves the error when including logrotate::hourly;
Error: /Stage[main]/Logrotate::Hourly/File[/etc/cron.hourly/logrotate]: Could not evaluate: Could not retrieve information from environment production source(s) puppet:///modules/logrotate/etc/cron.hourly/logrotate

@bastelfreak
Copy link
Member

Hi @zeromind, thanks for this PR!
Two little things:

  • Can you check the used email address in your commit? It is not associated with your github account
  • Can you add a little spec test that ensures this now works?

@bastelfreak bastelfreak added the bug Something isn't working label Oct 12, 2017
@tux-o-matic
Copy link

I created issue #85 before noticing this outstanding PR to fix the problem. +1 to see this PR merged and shipped in a new release on Forge.

@zeromind
Copy link
Author

@bastelfreak

  1. I've added the email address to my Github account now.
  2. I do not know how to write tests.

@osterhausm
Copy link

Any hope of getting this merged in?

@den-is
Copy link

den-is commented Jan 25, 2018

+1 when this fix for annoyance will be published ?

@joshuaspence
Copy link

+1. The logrotate::hourly class is currently broken

@zeromind
Copy link
Author

Seeems it got fixed via another pull request (#105), closing.

@zeromind zeromind closed this May 15, 2018
@den-is
Copy link

den-is commented May 25, 2018

is anybody going to release this fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants