Fix registration after an unsafe one #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neomilium
force-pushed
the
ensure-safe-registration
branch
from
3514d33
to
bfdb5aa
Compare
|
Tests look red :( |
neomilium
force-pushed
the
ensure-safe-registration
branch
from
bfdb5aa
to
de80416
Compare
neomilium
force-pushed
the
ensure-safe-registration
branch
from
de80416
to
e2a9e66
Compare
|
Fixed, thanks @ekohl |
ekohl
approved these changes
May 3, 2022
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Thanks to @ekohl for suggestion.
ekohl
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow user to register safely after using
unsafe_registrationflag.Issue details at #286
This Pull Request (PR) fixes the following issues
Fixes #286