Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Change the server or use --staging? #43

Closed
fvanboven opened this issue Jun 30, 2016 · 3 comments
Closed

Testing: Change the server or use --staging? #43

fvanboven opened this issue Jun 30, 2016 · 3 comments

Comments

@fvanboven
Copy link

fvanboven commented Jun 30, 2016

The readme states that the server configuration should be changed if you want to use the staging environment. But CertBot itself can handle this using the "-- staging" argument.

Isn't it perhaps a nice feature to make this a solid part of the module? To create a consistent way of testing and keeping the logic of the e.g. the staging server hostname out of the implementation.

Something like:

certbot::certonly { 'foo':
  domains => ['foo.example.com', 'bar.example.com'],
  staging => true,
}

Or make it a machine-wide config:

class { ::certbot:
  staging => true,
}

Any thoughts on this?

@danzilio
Copy link
Member

danzilio commented Jul 7, 2016

Hmm...this is an interesting idea. I wonder what this would mean for people using their own internal ACME server.

@cjeanneret
Copy link

@danzilio you might want to provide both way in your module: either use "default LE remotes" and using the --staging switch, or allow user to set his own remote - in that case, "staging" should not be passed (and ignored if passed).

@ekohl
Copy link
Member

ekohl commented Dec 4, 2018

Per our README: the answer is to change the server.

@ekohl ekohl closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants