[dev.icinga.com #13035] Wrong syntax of "apply" in object.conf.erb template (afaik)

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13035

Created by alorenzi on 2016-11-03 11:43:53 +00:00

Assignee: bsheqa
Status: Closed (closed on 2016-11-10 16:01:21 +00:00)
Target Version: v0.6.0
Last Update: 2016-11-10 16:18:46 +00:00 (in Redmine)

---

file: ./templates/object.conf.erb

at the moment it create a file like this:

apply for ( xxxxx )

should be

apply  "" to  etc etc etc 

---

Relations:

• relates #13035

[icinga-migration]

Updated by alorenzi on 2016-11-03 11:45:38 +00:00

[[https://github.com/LMNetworks/puppet-icinga2-rewrite/blob/develop\_objects/templates/object.conf.erb\]\]

[icinga-migration]

Updated by bsheqa on 2016-11-08 10:22:13 +00:00

• Target Version set to v0.6.0

[icinga-migration]

Updated by bsheqa on 2016-11-08 10:48:37 +00:00

Apply rules can be used in multiple ways. Generally an apply rule can target either a host or a service.
A Service apply rule targets a host implicitly, therefore you don't need to set a target in your icinga2 config. BUT you can do so if you wish.
Icinga2 is not consequent with the configuration here, because for all other object types that can be applied you must set the target. For services its optional.
An apply target can either be a service or a host, nothing else.

Beside the described default way, there is also a configuration with 'apply for'. With that you can create a loop to apply objects based on a set of arrays or hashes combined with expressions.

To cover all these cases, my solution would be this:

• When $apply is true or a string, the object is an apply rule. The 'apply' keyword must only be used in the template if $apply is not false.
• When parameter $apply_target is either 'Host' or 'Service' the rule will have a target, therefore will not be a 'apply for' loop. (apply $object_type to $apply_target)
• Check if $object_type and $apply_target are not the same. (A service cannot be applied to a service)
• If parameter $apply_target unset and $apply is a string, we create an 'apply for' loop with $apply as expression (apply for ($apply))

I would not differ service object types from other object types. Service apply rules can work without setting a target, but they also work with it. By setting the target for every object type we handle all types the same way and I like this better.

Please give me feedback on this. I hope this would cover all cases in a "simple to use" way.

[icinga-migration]

Updated by bsheqa on 2016-11-08 10:52:34 +00:00

• Relates set to 12349

[icinga-migration]

Updated by alorenzi on 2016-11-08 11:50:19 +00:00

Simple to use but hard to understand, i had to read a couple of times. :)

Anyway, make sense.

[icinga-migration]

Updated by bsheqa on 2016-11-10 16:01:21 +00:00

• Status changed from New to Closed
• Assigned to set to bsheqa
• Done % changed from 0 to 100

[icinga-migration]

Updated by alorenzi on 2016-11-10 16:18:46 +00:00

thanks :)