Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omniauth configuration misformated with extra quotes #140

Closed
InfernoZeus opened this issue Jun 22, 2017 · 2 comments
Closed

Omniauth configuration misformated with extra quotes #140

InfernoZeus opened this issue Jun 22, 2017 · 2 comments
Labels
bug Something isn't working

Comments

@InfernoZeus
Copy link

InfernoZeus commented Jun 22, 2017

I'm trying to configure this module with Omniauth settings for Github. I've added this to my Hiera yaml:

gitlab::gitlab_rails:
  omniauth_enabled: true
  omniauth_allow_single_sign_on: true
  block_auto_created_users: true
  omniauth_providers:
    - name: github
      app_id: xxx
      app_secret: xxx
      url: https://github.com
      args: "{ 'scope' => 'user:email' }"

The resulting gitlab.rb however is misformated:

gitlab_rails['omniauth_providers'] = '[
    {
        'name' => 'github',
        'app_id' => 'xxx',
        'app_secret' => 'xxx',
        'url' => 'https://github.com',
        'args' => { 'scope' => 'user:email' }
    }
]'

Notice the extra quotes around the list. How can I avoid these being injected?

@davidgubler
Copy link
Contributor

This may be related to #146

@juniorsysadmin juniorsysadmin added bug Something isn't working and removed puppet4 labels Jan 29, 2018
@LongLiveCHIEF
Copy link
Contributor

do you know what version/release of this module you were on when you were experiencing this issue? Specifically, I believe this may have been fixed when v.1.12 was released.

Also, I'd caution against putting omniauth configs in your hiera data unless it's encrypted , as it's a security risk to commit these secrets to your source control.

I haven't yet run into this in any other config item, and just due to lack of attention reports, I'm wondering how many configs would experience this issue if this is still a bug that needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants