Use different file name for processes plugin config #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes collectd::plugin::processes to work on RHEL-based systems again after a conflicting change on puppet-collectd v10.0.1. It uses a different filename for the processes plugin configuration in a way that it will no longer overwrite a vendor-supplied file that is being wiped as part of collectd::plugin.
bastelfreak
reviewed
Sep 29, 2018
| @@ -17,7 +17,7 @@ | |||
| 'collect_file_descriptor' => $collect_file_descriptor, | |||
| 'collect_memory_maps' => $collect_memory_maps, | |||
| }), | |||
| target => "${collectd::plugin_conf_dir}/processes-config.conf", | |||
| target => $::collectd::plugin::processes::config_file, | |||
There was a problem hiding this comment.
please don't add leading ::, that is only needed for puppet 3 (which we don't support anymore)
|
Hi @openglx, can you please take a look at the failing travis jobs? |
|
ping @openglx. This PR also requires a rebase. |
bastelfreak
added
needs-rebase
needs-work
archii
added a commit
to archii/puppet-collectd
that referenced
this pull request
Mar 25, 2019
Replicate commit from Pull Request voxpupuli#856
archii
added a commit
to archii/puppet-collectd
that referenced
this pull request
Mar 25, 2019
Resubmission of PR voxpupuli#856
archii
added a commit
to archii/puppet-collectd
that referenced
this pull request
Mar 26, 2019
Resubmission of PR voxpupuli#856
archii
added a commit
to archii/puppet-collectd
that referenced
this pull request
May 29, 2019
Resubmission of PR voxpupuli#856
|
Hi @openglx, are you still interested in this? |
My apologies but I haven't used the module in months due change in employment. Thank you for providing this module and your time. |
archii
added a commit
to archii/puppet-collectd
that referenced
this pull request
Sep 29, 2019
Resubmission of PR voxpupuli#856
archii
added a commit
to archii/puppet-collectd
that referenced
this pull request
Jan 18, 2020
Resubmission of PR voxpupuli#856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes collectd::plugin::processes to work on RHEL-based
systems again after a conflicting change on puppet-collectd v10.0.1.
It uses a different filename for the processes plugin configuration
in a way that it will no longer overwrite a vendor-supplied file that
is being wiped as part of collectd::plugin.
Pull Request (PR) description
Updates file name used for collectd::plugin::processes settings.
This Pull Request (PR) fixes the following issues
Fixes #851