Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version to fix compatability with puppet 7.28+ and 8.3+ #103

Closed
tedgarb opened this issue May 23, 2024 · 1 comment · Fixed by #114
Closed

Release new version to fix compatability with puppet 7.28+ and 8.3+ #103

tedgarb opened this issue May 23, 2024 · 1 comment · Fixed by #114
Assignees

Comments

@tedgarb
Copy link
Contributor

tedgarb commented May 23, 2024

Hello,

First, a bit of back context: Back in February, #65 was merged. This PR was originally written to address #64, which was addressed in an interim manner in #68 in 2022. As I alluded to in #64, I also submitted hercules-team/augeas#721, which would not be sufficiently addressed with #68, but would in #65, which flexibly handles augeas updates to which labels were strings and which were arrays. hercules-team/augeas#721 was merged back in November 2022, and we thus set up a situation where if a puppet update incorporated that change before #65 was merged and released, this module would break in the same way as #64 and #68 originally described.

With that background explained; Puppet 8.3 was released in November 2023, and Puppet 7.28 was released in January 2024, both incorporating a bump of augeas from 1.13.0 to 1.14.1, which includes hercules-team/augeas#721 . As noted in https://www.puppet.com/docs/puppet/7/release_notes_puppet#enhancements_puppet_x-7-28-0-PA-5944 and https://www.puppet.com/docs/puppet/8/release_notes_puppet#enhancements_puppet_x-8-3-0-PA-4938, this breaks the use of augeas in the way predicted in #64, because the label is now an array and not a string. This was also observed in #99 on this repository.

I have tested in my local environment, and in order to address this situation with the use of the module, my change in #65 must be present. This change is also confirmed backwards-compatible with pre-7.28/8.3 .

Therefore, I humbly ask that a new release of this module be cut when possible, to allow for people not able to run from the git repo that is ahead of the latest release to be able to address this issue. A release note highlighting the puppet release notes would also be appreciated, as I believe people may need to further adjust their config/use of the module to switch from a string to an array.

@tedgarb
Copy link
Contributor Author

tedgarb commented Sep 25, 2024

Checking in, is there any way we could arrange for a new release at some point soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants