Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentOS-5 Nodeset Retirement CentOS 5 EOL March 31st, 2017 #293

Closed
sacres opened this issue Dec 31, 2016 · 9 comments
Closed

CentOS-5 Nodeset Retirement CentOS 5 EOL March 31st, 2017 #293

sacres opened this issue Dec 31, 2016 · 9 comments

Comments

@sacres
Copy link
Member

sacres commented Dec 31, 2016

As per: CentOS 5 EOL .
We should plan to remove the CentOS-5 nodesets, yes?

@juniorsysadmin
Copy link
Member

YesNo. The bigger question is: Should we be dropping support for certain operating systems in modules when they go End of Life ?

@sacres
Copy link
Member Author

sacres commented Jan 1, 2017

I vote +1 to drop. EOL is a fairly static concept.

@vinzent
Copy link
Contributor

vinzent commented Jan 2, 2017

remove operating systems from supported OS'es when they reached EOL - not only restricted to CentOS.

@sacres
Copy link
Member Author

sacres commented Jan 6, 2017

Yes, that as well @vinzent. I presented this specific use-case as it's immediately relevant as well as a pathway to standardizing this process.

@ekohl
Copy link
Member

ekohl commented Nov 17, 2017

Now that the date has passed for a while 👍

@ekohl
Copy link
Member

ekohl commented Nov 17, 2017

#425 adds tooling to easily do this.

@bastelfreak
Copy link
Member

This can now be closed. We dropped the docker nodesets in the last modulesync run (today). Also RHEL 5 got removed from all metadata.json files.

@ekohl
Copy link
Member

ekohl commented May 20, 2018

@bastelfreak did the nodesets actually got removed? AFAIK modulesync doens't remove files when they become unmanaged. I have a bunch of commits ready that I haven't pushed yet but they're nothing special. Assuming clean up to date checkouts:

for module in modules/* ; do
( cd $module && git checkout -b remove-docker-nodesets && git rm -r spec/acceptance/nodesets/docker && git commit -av -m "Remove docker nodesets && git push origin HEAD -u && hub pull-request -m "Remove docker nodesets" )
done

There is also some special care that some windows modules need to remove https://github.com/voxpupuli/puppet-windows_env/blob/3176c2fdbe611bad6725144f2060a397513145ca/.sync.yml#L4-L19. A last mention is that I think puppet-fail2ban and puppet-puppetserver both haven't been converted.

@bastelfreak
Copy link
Member

I made some false assumptions about the cleanup script. The nodesets are present but we removed RHEL 5 from the metadata.json (and all other EOL operating systems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants