Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump needed ruby version for forge release #135

Closed
bastelfreak opened this issue Apr 28, 2016 · 10 comments
Closed

Bump needed ruby version for forge release #135

bastelfreak opened this issue Apr 28, 2016 · 10 comments

Comments

@bastelfreak
Copy link
Member

Our current release part in the .travis.yml:

  on:
    tags: true
    # all_branches is required to use tags
    all_branches: true
    # Only publish if our main Ruby target builds
    rvm: 1.9.3
    condition: "$FUTURE_PARSER = yes"

We should bump that, we don't test on 1.9.3 anymore. Which version do we want to target here? 2.3.0? I would use that one because it does rubocp + spec tests. But then we may remove 2.3.0 from the allow_failures category.

@jyaworski
Copy link
Member

jyaworski commented Apr 28, 2016

We do test on 1.9.3 via jruby-193mode.

@bastelfreak
Copy link
Member Author

bastelfreak commented Apr 28, 2016

Do we want that a jruby version as our main target?

@jyaworski
Copy link
Member

In my opinion, yes. It's puppetserver 1.1.3, which is the 'latest stable' per-se on 3.x.

@rnelson0
Copy link
Member

rnelson0 commented Apr 28, 2016 via email

@rnelson0 rnelson0 reopened this Apr 28, 2016
@rnelson0
Copy link
Member

This does need to be changed before its closed. There is currently no 1.9.3 in the matrix so no new builds will deploy. Changing it to 2.2 should work. On a tablet right now though.

@bastelfreak
Copy link
Member Author

ahhhhhh

@bastelfreak
Copy link
Member Author

so we talked so much about semantic versioning in the last days. Should we add a new tag to this repo and if so, is this a minor or patch release? I would vote for patch.

@rnelson0
Copy link
Member

Patch

Rob Nelson
[email protected]

@juniorsysadmin
Copy link
Member

Always update PATCH for modulesync_config tags

@bastelfreak
Copy link
Member Author

I pushed 0.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants