-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump needed ruby version for forge release #135
Comments
We do test on 1.9.3 via jruby-193mode. |
Do we want that a jruby version as our main target? |
In my opinion, yes. It's puppetserver 1.1.3, which is the 'latest stable' per-se on 3.x. |
It doesn't matter which rvm, really, you just want it to be unique. It was
set to 1.9.3 because `FUTURE_PARSER` isn't unique, then one build succeeds
and another generates an error, marking the build as failed which shows up
in the badges.
|
This does need to be changed before its closed. There is currently no 1.9.3 in the matrix so no new builds will deploy. Changing it to 2.2 should work. On a tablet right now though. |
ahhhhhh |
so we talked so much about semantic versioning in the last days. Should we add a new tag to this repo and if so, is this a minor or patch release? I would vote for patch. |
Patch Rob Nelson |
Always update PATCH for modulesync_config tags |
I pushed 0.5.1. |
Our current release part in the .travis.yml:
We should bump that, we don't test on 1.9.3 anymore. Which version do we want to target here? 2.3.0? I would use that one because it does rubocp + spec tests. But then we may remove 2.3.0 from the allow_failures category.
The text was updated successfully, but these errors were encountered: