Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide compiled binaries #108

Open
Nyoroon opened this issue Apr 17, 2019 · 12 comments
Open

Provide compiled binaries #108

Nyoroon opened this issue Apr 17, 2019 · 12 comments

Comments

@Nyoroon
Copy link

Nyoroon commented Apr 17, 2019

Hello!

It would be very useful to have pre-compiled binaries for those who deploy it on bare-metal and VM.
Maybe build it with travis and push to github releases?

@bnfinet
Copy link
Member

bnfinet commented Apr 17, 2019

Thanks for the suggestion. Its a good idea.

To offer a static binary as a release we'd need to include the additional static files which get served by the webapp.

The go generate method outlined here seems like a viable path..
https://stackoverflow.com/questions/17796043/how-to-embed-files-into-golang-binaries

And of course storing the MD5 checksum

@halkeye setup travis for Vouch Proxy so he may have some thoughts as well.

@Nyoroon is this something you'd care to work on?

@rlex
Copy link

rlex commented May 26, 2020

Maybe just pack static files in same .tar.gz/.zip/whatever? That's gonna be enough for configuration management systems.

@halkeye
Copy link
Member

halkeye commented May 26, 2020

I don't remember this issue at all. Go releaser is pretty good for uploading files to the releases tab, but yea the static templates that are external certainly make things more complicated

Goreleaser should be able to do it

@rlex
Copy link

rlex commented May 27, 2020

Definitely will be better than just source and docker images, i think.

Plus might be easier to customize. Looking at git history, templates are pretty stable and rarely changed?

@bnfinet
Copy link
Member

bnfinet commented Jun 9, 2020

This action may be the mechanism to publish the binaries with each release. Still need to bundle the other files.
https://github.com/skx/github-action-publish-binaries

@hbjydev
Copy link

hbjydev commented May 18, 2022

@bnfinet You potentially could distribute the static assets separately and require the administrator to define the location to those assets?

i.e. vouch-proxy -static.path=/opt/vouch-proxy/static/ or similar

@bnfinet
Copy link
Member

bnfinet commented May 18, 2022

@hbjydev this issue is showing it's age. As of v0.29.0 all static assets are embedded in the binary..
https://github.com/vouch/vouch-proxy/blob/master/CHANGELOG.md#v0290

@hbjydev
Copy link

hbjydev commented May 18, 2022

@hbjydev this issue is showing it's age. As of v0.29.0 all static assets are embedded in the binary..

https://github.com/vouch/vouch-proxy/blob/master/CHANGELOG.md#v0290

Ah, sorry about that. I was looking at bare metal installation stuff and stumbled on this randomly so I didn't see the changelog

@nuclon
Copy link

nuclon commented Oct 4, 2023

@hbjydev this issue is showing it's age. As of v0.29.0 all static assets are embedded in the binary.. https://github.com/vouch/vouch-proxy/blob/master/CHANGELOG.md#v0290

So now it is possible to publish binaries with each release, right?
Any plans on implementing?

@halkeye
Copy link
Member

halkeye commented Oct 4, 2023

@bnfinet is the only one that can do releases, and he hasn't been online in a while,no activity in github, twitter hasn't been updated since 2020, and website is now gone. My guess is something happened. Nm, I see a comment from him a few months ago :)

I would recommend if you want the feature implemented, you fork and do it. Maybe @aaronpk (as a member of core) might have merging and releasing rights. But i'd still think project needs to find a new home.

@bnfinet
Copy link
Member

bnfinet commented Oct 4, 2023

:) yeah I'm around, I'm just extremely choosey at the moment

Sorry for some cobwebs here. I do expect to get back to VP once it starts raining in earnest. Until then I have to prioritize other life goals.

@fukawi2
Copy link

fukawi2 commented Oct 30, 2023

Looks like this could be automated fairly simply with GitHub Actions: https://dev.to/koddr/github-action-for-release-your-go-projects-as-fast-and-easily-as-possible-20a2

Would you be interested in a PR implementing this @bnfinet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants