test(dev-dock/backend): move from jest to vitest
#5739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eventualbuddha
force-pushed
the
5735-libsdev-dockbackend
branch
from
358fcd0 to
ea2ec34
Compare
jonahkagan
approved these changes
Dec 12, 2024
| ...(await importActual<typeof import('@votingworks/utils')>()), | ||
| isFeatureFlagEnabled: (flag) => featureFlagMock.isEnabled(flag), | ||
| }) | ||
| ); |
There was a problem hiding this comment.
What's this new pattern of passing in importActual rather than just using vi.importActual? Also what are all the type annotations for?
There was a problem hiding this comment.
This is what @kofi-q's script generated, which seemed a little nicer than having to repeat the string. The type annotation on the importActual call tells it to treat the return type as the import of that module, and the type annotation at the return position of the call to vi.mock's callback tells it to expect an object of that type. This should ensure we don't miss anything or typo an export name.
There was a problem hiding this comment.
Nice, thanks for explaining!
This way we can replace the `jest` with `vi` at individual callsites as we get to them.
eventualbuddha
force-pushed
the
brian/refactor/test/inline-advancetimers
branch
from
0d00519 to
72265b0
Compare
eventualbuddha
requested review from
adghayes and
arsalansufi
as code owners
eventualbuddha
force-pushed
the
5735-libsdev-dockbackend
branch
from
ea2ec34 to
3de6d01
Compare
Base automatically changed from
brian/refactor/test/inline-advancetimers
to
vitest
December 12, 2024 18:56
eventualbuddha
added a commit
that referenced
this pull request
Dec 19, 2024
* refactor(jest): inline calls to `advanceTimers` This way we can replace the `jest` with `vi` at individual callsites as we get to them. * test(dev-dock/backend): move from `jest` to `vitest` * test(dev-dock/backend): remove outdated jest config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5735
advanceTimers#5738