Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VxDesign: Validate image uploads #5866

Closed
jonahkagan opened this issue Jan 22, 2025 · 0 comments
Closed

VxDesign: Validate image uploads #5866

jonahkagan opened this issue Jan 22, 2025 · 0 comments
Assignees

Comments

@jonahkagan
Copy link
Collaborator

jonahkagan commented Jan 22, 2025

For seals:

  • Background is transparent (if not SVG) --> Can punt on this one
  • Minimum size: 200x200px
  • Maximum size: TBD - investigate this as part of this task

Reject the upload and return an error message if any of the conditions isn't met.

Also consider:

  • Clerk signatures
  • Ballot measure images

Generally safe to assume: 1 seal, 2 clerk signatures, 1 ballot measure image

Clerk signature notably doesn't go into the election package.

Note that non-seal images are converted to base64 SVGs, so they grow in size. Current limits on upload end (5MB) apply to original upload, not converted file. Let's check the converted file.

Main guiding principle: Don't crash VxDesign or slow down VxSuite with gigantic election defs. Ballot looks okay.

@jonahkagan jonahkagan added this to the VxDesign Self-Serve Pilot milestone Jan 22, 2025
@arsalansufi arsalansufi changed the title VxDesign: Validate seal image upload VxDesign: Validate image uploads Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants